feat: implement command -p
#402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR implements the command –p functionality, rebasing against recent changes and moving platform‐specific code under the sys module. Key changes include:
- Updating command behavior to support the –p flag by modifying both the builtins and command execution logic.
- Adjusting the shell’s PATH resolution and default executable search paths.
- Adding new compatibility tests and updating platform-specific filesystem utilities.
Reviewed Changes
| File | Description |
|---|---|
| brush-core/src/builtins/command.rs | Modified command lookup and execution to support use_default_path; updated try_find_command signature. |
| brush-core/src/shell.rs | Updated PATH initialization and refactored executable search functions to use default paths. |
| brush-core/src/sys/unix/fs.rs | Added constants and functions for executable and standard utils path retrieval, including confstr integration. |
| brush-shell/tests/cases/builtins/command.yaml | Added new test cases for command -p functionality and command -v -p usage. |
| brush-core/src/commands.rs | Modified command execution to accept an optional path_dirs parameter for enhanced external command lookup. |
| brush-core/src/sys/stubs/fs.rs | Stub implementations updated for default path functions. |
| brush-core/src/interp.rs | Adapted function calls to new execute signature with path_dirs parameter. |
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Test Results 2 files 9 suites 1m 35s ⏱️ Results for commit f7891b2. ♻️ This comment has been updated with latest results. |
Performance Benchmark Report
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is Test Summary: bash-completion test suite
|
Adjusts previous changes to address earlier PR feedback; adds tests.
reubeno
force-pushed
the
command-p-revisited
branch
from
62bd2e7 to
f7891b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebases #200 against latest changes in tree + adapts to move platform-specific code under
sys. Also adds a couple of basic compat tests to cover the functionality.Huge credit to @39555 for sorting out the problem and getting this working! I've created this under a separate PR to avoid stomping on the previous branch.